Skip to content

chore: remove unused EnvVarUtils.validateEnvVars methods - #32781

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-envvarutils-validateenvvars-me-6b758e
Open

chore: remove unused EnvVarUtils.validateEnvVars methods#32781
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-envvarutils-validateenvvars-me-6b758e

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 7, 2026

Copy link
Copy Markdown

Remove the public validateEnvVars method and its private validateEnvVar helper from EnvVarUtils, along with their dedicated tests, since they had no production callers anywhere in the codebase (only test-internal usage, explicitly excluded by the dead-code policy). The rest of EnvVarUtils remains in active use via PodManager.buildContainer -> sanitizeEnvVars.

History

Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from pmbrull September 7, 2026 00:24
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 190aeaf815fdc9b34a3c4d2392b560849d14aba1 in Playwright run 34070985507, attempt 1.

✅ 556 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 47m 9s

⏱️ Max setup 5m 7s · max shard execution 18m 29s · max shard-job elapsed before upload 21m 31s · reporting 6s

🌐 234.97 requests/attempt · 2.82 app boots/UI scenario · 12.98% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 234.97 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.82 per UI scenario (1634 boots / 579 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 147 0 0 0 0 0
✅ Shard chromium-02 130 0 0 0 0 0
🟡 Shard chromium-03 121 0 1 0 0 0
✅ Shard data-asset-rules-01 65 0 0 0 0 0
✅ Shard domain-isolation-01 16 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0
🟡 1 flaky test(s) (passed on retry)
  • Pages/Entity.spec.ts › Announcement create, edit & delete (shard chromium-03, 1 retry)

📦 Download artifacts

How to debug locally 
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@detail-app detail-app Bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmbrull pmbrull Awaiting requested review from pmbrull

At least 1 approving review is required to merge this pull request.

Assignees

@pmbrull pmbrull

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pmbrull